Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hiddenInstanceFields to the VM snapshot #20759

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ThanHenderson
Copy link
Contributor

On restore runs, hidden instance fields have already been added. This patch adds the JavaVM::hiddenInstanceFields to the snapshot and adds the functionality to find and fill-in the hidden instance field's correct offset during restore runs.

Related: #20612

Signed-off-by: Nathan Henderson [email protected]

On restore runs, hidden instance fields have already been added.
This patch adds the JavaVM::hiddenInstanceFields to the snapshot
and adds the functionality to find and fill-in the hidden
instance field's correct offset during restore runs.

Related: eclipse-openj9#20612
Signed-off-by: Nathan Henderson <[email protected]>
@ThanHenderson
Copy link
Contributor Author

@babsingh Could you review this too?

These changes are independent of #20740 but my follow up patches for snapshot modularity support depend both on this PR and the one linked. Non-snapshot enabled builds are not affected by this change; the behaviour should be the same.

@babsingh
Copy link
Contributor

babsingh commented Dec 5, 2024

jenkins test sanity.functional zlinux jdk8

@babsingh
Copy link
Contributor

babsingh commented Dec 5, 2024

jenkins test sanity.functional plinux jdk11

@babsingh
Copy link
Contributor

babsingh commented Dec 5, 2024

jenkins test sanity.functional alinux jdk17

@babsingh
Copy link
Contributor

babsingh commented Dec 5, 2024

jenkins test sanity.functional amac jdk21

@babsingh babsingh merged commit ef98195 into eclipse-openj9:master Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants