Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore class loading errors in LoadableDescriptors #20652

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

theresa-m
Copy link
Contributor

Ignore ClassCircularityError created by LoadableDescriptors lists. I encountered this error when trying to enable migrated value classes #20386

Related to #19119

class Test {
        public static void main(String[] args) throws Throwable {
                Circ c = new Circ();
        }
}

value class Circ {
        static Circ2 c2;
        /* LoadableDescriptors list contains Circ2 */
}

value class Circ2 {
        static Circ c;
        /* LoadableDescriptors list contains Circ */
}

@theresa-m theresa-m requested a review from hangshao0 November 20, 2024 18:50
@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Nov 20, 2024
@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,extended plinuxval jdknext

Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0 hangshao0 merged commit 28a6b3e into eclipse-openj9:master Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants