Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java Behaviour w.r.t Math.max and Math.min for Floating Points #20465

Closed
wants to merge 0 commits into from

Conversation

matthewhall2
Copy link
Contributor

  • Enables inlining of Math.max/Math.min functions for floats and doubles
  • Implements Java standard found while testing
    • +0 compares as strictly greater than -0
    • if the first arg is a NaN, returns the corresponding quiet NaN, same for if only the second arg is a NaN

This is the same as #20185 with the functional test change removed

@matthewhall2 matthewhall2 requested a review from dsouzai as a code owner October 31, 2024 16:18
@pshipton
Copy link
Member

The original change was causing crashes on z/OS.

@pshipton
Copy link
Member

Setting as draft until the z/OS problems are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants