Clean Up VM Access in J9SymbolReferenceTable.cpp #20439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the redundant VM Access critical section before getObjectClassAt(), since TR_J9VMBase::getObjectClassAt() will acquire/release VM Access internally, and TR_J9ServerVM::getObjectClassAt() will query the client instead. Signed-off-by: Luke Li <[email protected]>
|
@mpirvu can you review this? |
mpirvu
reviewed
Oct 30, 2024
|
@jdmpapin Could you please review this PR as well? Thanks |
|
jenkins test sanity all jdk21 |
jdmpapin
approved these changes
Oct 31, 2024
|
plinux had a crash in jdk_lang_0. I started a 5 iteration grinder here: https://openj9-jenkins.osuosl.org/job/Grinder/3939/ |
|
Grinders passed, so I am going to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the redundant VM Access critical section before getObjectClassAt(), since TR_J9VMBase::getObjectClassAt() will acquire/release VM Access internally, and
TR_J9ServerVM::getObjectClassAt() will query the client instead.