Accelerate Unsafe CAS Intrinsics on Aarch64 #20432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the following recognized methods: CompareAndExchangeObject //JDK11 CompareAndExchangeReference //JDK17,21 CompareAndExchangeInt //JDK11,17,21 CompareAndExchangeLong //JDK11,17,21 The accelerated CAE code was built on top of the existing accelerated CAS support on Arm. Changes are similar to previously added support on Power, X and Z. Cleans up isUnsafeCAS to remove the now unused comp parameter. Also cleans up isUnsafeWithObjectArg, isVarHandleAccessMethod and isSignaturePolymorphicMethod to remove unused comp parameters. Signed-off-by: jimmyk <[email protected]>
|
@hzongaro When you get a chance, can you look over the common changes here as well? |
|
@knn-k I haven't had to submit Arm changes before. Are you the one I need to ask to review Arm changes or is there someone else? |
hzongaro
approved these changes
Oct 29, 2024
knn-k
reviewed
Oct 30, 2024
knn-k
reviewed
Oct 30, 2024
knn-k
reviewed
Oct 30, 2024
Updates comments and remove unneeded 64bit checks for genCAS on Aarch64.
|
Jenkins test sanity alinux64,amac jdk17 depends eclipse-omr/omr#7505 |
|
Jenkins test sanity.system amac jdk17 depends eclipse-omr/omr#7505 |
|
Jenkins compile xlinux,plinux jdk21 depends eclipse-omr/omr#7505 |
|
I tried to perform a coordinated merge with eclipse-omr/omr#7505, but the Mirror-OMR-To-OpenJ9-OMR job in the procedure failed unexpectedly. |
|
It's fixed now. |
|
Merging now. |
knn-k
added
the
depends:omr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following recognized methods:
The accelerated CAE code was built on top of the existing accelerated CAS support on Arm. Changes are similar to previously added support on Power, X and Z.
Cleans up
isUnsafeCASto remove the now unusedcompparameter. Also cleans upisUnsafeWithObjectArg,isVarHandleAccessMethodandisSignaturePolymorphicMethodto remove unused comp parameters.Edit:
Needs to be check in with:
eclipse-omr/omr#7505
Due to the changes to the parameters of
isUnsafeCASandisUnsafeWithObjectArg.