Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a null check for J9JavaVM->bytecodeVerificationData #20422

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add a null check for J9JavaVM->bytecodeVerificationData #20422

merged 1 commit into from
Oct 29, 2024

Conversation

babsingh
Copy link
Contributor

Related: #14191

@babsingh babsingh mentioned this pull request Oct 28, 2024
Closed
@babsingh babsingh marked this pull request as ready for review October 28, 2024 18:33
@babsingh babsingh requested review from fengxue-IS and tajila October 28, 2024 18:33
fengxue-IS
fengxue-IS approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fengxue-IS fengxue-IS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

related question, is -Xverify:none the only path that sets vm->bytecodeVerificationData to NULL? if there could be other paths, we will need an additional check to ensure cl constraint is done properly.

@babsingh
Copy link
Contributor Author

babsingh commented Oct 28, 2024 •
edited
Loading

is -Xverify:none the only path that sets vm->bytecodeVerificationData to NULL?

The relationship between -Xverify:none and bytecodeVerificationData being set to NULL is implicit. But, I don't see other paths which can set bytecodeVerificationData to NULL. @fengxue-IS Can you double check for the paths on your end?

@tajila
Copy link
Contributor

tajila commented Oct 28, 2024

jenkins test sanity alinux64 jdk21

@babsingh
Copy link
Contributor Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_aarch64_linux_Personal_testList_1/235/testReport

Only one known and unrelated failure (JITServerTest.testServerUnreachableForAWhile) is seen in the builds: #14594

@tajila tajila merged commit e577d65 into eclipse-openj9:master Oct 29, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila approved these changes

@fengxue-IS fengxue-IS fengxue-IS approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babsingh @tajila @fengxue-IS @pshipton