Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IS_REF_OR_VAL_SIGNATURE to IS_CLASS_SIGNATURE #20160

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Sep 12, 2024

  • Rename IS_REF_OR_VAL_SIGNATURE to IS_CLASS_SIGNATURE
  • Rename isRefOrValSignature to isClassSignature

These names refer to ReferenceType from an old value types specification draft which is no longer in use https://cr.openjdk.org/~dlsmith/jep401/jep401-20211220/specs/primitive-classes-jvms.html#jvms-4.3.2. Rename these to reflect the current meaning.

Related to #18157

@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Sep 12, 2024
@theresa-m theresa-m requested a review from hangshao0 September 13, 2024 15:05
@keithc-ca
Copy link
Contributor

Is "class" the right concept, or should it be "type"?

@theresa-m
Copy link
Contributor Author

theresa-m commented Sep 20, 2024

Is "class" the right concept, or should it be "type"?

Its referring to ClassType so maybe IS_CLASSTYPE_SIGNATURE ?

But given that this language isn't used much in the jvm spec I think IS_CLASS_SIGNATURE is sufficiently descriptive.

@keithc-ca
Copy link
Contributor

It's my understanding that Valhalla is working towards removing the distinction between class types and value types, so while "ClassType" is better, I think "Type" is more general (the type in question may not be a "class" as the name would imply).

@theresa-m
Copy link
Contributor Author

I see what you mean, but currently the "regular classes" are known as identity classes and value types are value classes. Class encompasses both types.

@keithc-ca
Copy link
Contributor

Ok, then "class" is fine. Thanks.

@keithc-ca
Copy link
Contributor

Please address the merge conflict.

@keithc-ca
Copy link
Contributor

Jenkins test sanity amac jdk23

@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,extended zlinuxval jdknext

@hangshao0 hangshao0 merged commit 94886ed into eclipse-openj9:master Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants