-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename IS_REF_OR_VAL_SIGNATURE to IS_CLASS_SIGNATURE #20160
Conversation
Is "class" the right concept, or should it be "type"? |
Its referring to ClassType so maybe IS_CLASSTYPE_SIGNATURE ? But given that this language isn't used much in the jvm spec I think IS_CLASS_SIGNATURE is sufficiently descriptive. |
It's my understanding that Valhalla is working towards removing the distinction between class types and value types, so while "ClassType" is better, I think "Type" is more general (the type in question may not be a "class" as the name would imply). |
I see what you mean, but currently the "regular classes" are known as identity classes and value types are value classes. Class encompasses both types. |
Ok, then "class" is fine. Thanks. |
Please address the merge conflict. |
Signed-off-by: Theresa Mammarella <[email protected]>
Signed-off-by: Theresa Mammarella <[email protected]>
c6a93e4
to
c5d78f9
Compare
Jenkins test sanity amac jdk23 |
Jenkins test sanity.functional,extended zlinuxval jdknext |
These names refer to ReferenceType from an old value types specification draft which is no longer in use https://cr.openjdk.org/~dlsmith/jep401/jep401-20211220/specs/primitive-classes-jvms.html#jvms-4.3.2. Rename these to reflect the current meaning.
Related to #18157