Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove evaluators for String.compressNoCheck() #19954

Closed
wants to merge 1 commit into from
Closed

Remove evaluators for String.compressNoCheck() #19954

wants to merge 1 commit into from

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jul 31, 2024

This commit removes compressStringNoCheckEvaluator() for p and x platforms. They are no longer used because there is no compressNoCheck() method in the String class.

@knn-k
Copy link
Contributor Author

knn-k commented Jul 31, 2024

Jenkins test sanity plinux,xlinux jdk8,jkd21

@knn-k
Copy link
Contributor Author

knn-k commented Aug 1, 2024

Jenkins test sanity plinux,xlinux jdk8,jdk21

@knn-k
Copy link
Contributor Author

knn-k commented Aug 2, 2024

Jenkins test sanity xlinux jdk8,jdk21

@pshipton
Copy link
Member

pshipton commented Aug 2, 2024

Jenkins test sanity xlinux jdk21

@knn-k
Remove evaluators for String.compressNoCheck()
7ec6019 
This commit removes compressStringNoCheckEvaluator() for p and x
platforms.  They are no longer used because there is no
compressNoCheck() method in the String class.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k knn-k force-pushed the removeStringCompressNoCheck branch from 6fc3ddc to 7ec6019 Compare August 5, 2024 00:58
@knn-k
Copy link
Contributor Author

knn-k commented Aug 5, 2024

Jenkins test sanity xlinux jdk8,jdk21

@knn-k
Copy link
Contributor Author

knn-k commented Aug 7, 2024

Something is going wrong with Java 8 on x86-64 Linux. I have seen failures with testJitserverArguments_0 every time I tried.

@pshipton
Copy link
Member

pshipton commented Aug 12, 2024 •
edited
Loading

testJitserverArguments_0 fails on the cent6 machines, it's a known problem.
#18599

00:18:27   [ERR] /home/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_linux_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/jitserver/jitserverconfig.sh: line 30: lsof: command not found
00:18:27   [ERR] /home/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_linux_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/jitserver/jitserverconfig.sh: line 30: lsof: command not found
00:18:27   [ERR] Generating RSA private key, 2048 bit long modulus
00:18:27   [ERR] ...........................................+++
00:18:27   [ERR] ...............................................+++
00:18:27   [ERR] e is 65537 (0x10001)
00:18:27   [ERR] Generating a 2048 bit RSA private key
00:18:27   [ERR] .............................+++
00:18:27   [ERR] ..........+++
00:18:27   [ERR] writing new private key to 'wrongKey.pem'
00:18:27   [ERR] -----
00:18:27   [ERR] failed to configure SSL ecdh: Success
00:18:27   [ERR] Failed to initialize the SSL context

@knn-k knn-k marked this pull request as ready for review August 19, 2024 02:58
@knn-k knn-k requested a review from dsouzai as a code owner August 19, 2024 02:58
@knn-k
Copy link
Contributor Author

knn-k commented Aug 19, 2024

I changed the state to "ready for review".

@knn-k
Copy link
Contributor Author

knn-k commented Sep 27, 2024

Jenkins test sanity xlinux jdk8

@knn-k
Copy link
Contributor Author

knn-k commented Oct 1, 2024

This PR is superseded by PR #20280. Closing.

@knn-k knn-k closed this Oct 1, 2024
@knn-k knn-k deleted the removeStringCompressNoCheck branch October 2, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees
No one assigned
Labels
arch:power arch:x86 comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @pshipton