Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Class.isPrimitiveClass and outdated methods #19736

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Remove Class.isPrimitiveClass and outdated methods #19736

merged 1 commit into from
Jun 24, 2024

Conversation

theresa-m
Copy link
Contributor

Related to #18157

Closes: #13615

@theresa-m theresa-m requested a review from hangshao0 June 19, 2024 16:16
@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Jun 19, 2024
@theresa-m theresa-m requested a review from dsouzai as a code owner June 20, 2024 20:27
@theresa-m theresa-m requested a review from hangshao0 June 20, 2024 20:28
@hangshao0
Copy link
Contributor

There are code changes in JIT here related to the removal of Class.isPrimitiveClass(). Adding @hzongaro and @a7ehuo as reviewers.

@hangshao0 hangshao0 requested review from hzongaro and a7ehuo June 21, 2024 14:38
@a7ehuo
Copy link
Contributor

a7ehuo commented Jun 21, 2024

The related change in the JIT under runtime/compiler for the removal of java_lang_Class_isPrimitiveClass looks good to me. Thank you very much for the update @theresa-m!

hzongaro
hzongaro approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JIT changes look good to me. Thanks!

@hangshao0
Copy link
Contributor

@theresa-m There is a merge conflict.

@theresa-m
Copy link
Contributor Author

I fixed the merge conflict.

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended zlinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended amac jdk21

@hangshao0 hangshao0 merged commit 7905c54 into eclipse-openj9:master Jun 24, 2024
9 checks passed
@theresa-m theresa-m mentioned this pull request Oct 10, 2024
Closed
@theresa-m theresa-m deleted the remove_q_2 branch October 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@hangshao0 hangshao0 hangshao0 approved these changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

@a7ehuo a7ehuo Awaiting requested review from a7ehuo

Assignees
No one assigned
Labels
comp:jit comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueTypes: add new java.lang.Class API methods
4 participants
@theresa-m @hangshao0 @a7ehuo @hzongaro