Avoid calling getEnclosingBlock #16455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While performing analysis for flush elimination, LocalFlushElimination::examineNode called TR::TreeTop::getEnclosingBlock on the current TR::TreeTop. As that method walks through the linked list chaining together the TR::TreeTops to find the corresponding BBStart, calling it in nested loops becomes very expensive when large blocks are encountered. Fixed this by passing the current block as an argument to LocalFlushElimination::examineNode Signed-off-by: Henry Zongaro <[email protected]>
|
Vijay @vijaysun-omr, may I ask you to review this change? |
|
Jenkins test sanity all jdk8,jdk11,jdk19 |
vijaysun-omr
approved these changes
Dec 12, 2022
|
Checks have passed. Merging. |
|
I think we need this fix in the v0.36 branch, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While performing analysis for flush elimination,
LocalFlushElimination::examineNodecalledTR::TreeTop::getEnclosingBlockon the currentTR::TreeTop. As that method walks through the linked list chaining together theTR::TreeTops to find the correspondingBBStart, calling it in nested loops becomes very expensive when large blocks are encountered.Fixed this by passing the current block as an argument to
LocalFlushElimination::examineNode.Fixes #16353