Created FlattenedContiguousArrayIterator for FA iteration #11714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OussamaSaoudi
force-pushed
the
GCFlattenedContiguousArrayIterator
branch
2 times, most recently
from
4d160c4
to
0c31134
Compare
OussamaSaoudi
force-pushed
the
GCFlattenedContiguousArrayIterator
branch
2 times, most recently
from
8c5cdf4
to
2767a13
Compare
OussamaSaoudi
force-pushed
the
GCFlattenedContiguousArrayIterator
branch
2 times, most recently
from
c6a4499
to
c739dee
Compare
Created iterator which has nextSlot() method to sequentially return slots found inside a Flattened Array. -Implements getIndex(), setIndex(int) getter and setter method for index within the flattened array. -Implements save(ObjectIteratorState) and restore(ObjectIteratorState) methods to save scan and end pointers to objectIteratorState, or set the scan and end pointers from the objectIteratorState. -Implements getObject() to return pointer to the array. Created new CopmactSchemeFixupObject method: fixupFlattenedArrayObject, which allows the gc compacter to copmact flattened arrays using FlattenedContiguousArrayIterator. Modified VT tests to allow for compacting by removing -Xnocompactgc flag. Signed-off-by: Oussama Saoudi <[email protected]>
OussamaSaoudi
force-pushed
the
GCFlattenedContiguousArrayIterator
branch
from
c739dee
to
aa0f6ed
Compare
| { | ||
| /* If no more object slots to scan, returns NULL */ | ||
| GC_SlotObject *result = NULL; | ||
| if (_scanPtr < _endPtr) { |
There was a problem hiding this comment.
This check is a cost of skipping initialization of _mixedObjectIterator in initialize() for case of zero length array. It is quite expensive because should be done for every single returning slot. However the only alternative I see is a modification of GC_MixedObjectIterator that way we can get NULL from first call of _mixedObjectIterator.nextSlot() and I don't like it either. So I am ok with current implementation if there is no better proposals
amicic
approved these changes
Jan 21, 2021
|
@tajila Would you please review test update part? |
dmitripivkine
approved these changes
Jan 21, 2021
|
Jenkins test sanity xlinuxvalst jdknext |
|
Jenkins test sanity,extended xlinuxval jdknext |
tajila
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created iterator which has nextSlot() method to sequentially
return slots found inside a Flattened Array.
-Implements getIndex(), setIndex(int) getter and setter method for
index within the flattened array.
-Implements save(ObjectIteratorState) and restore(ObjectIteratorState)
methods to save scan and end pointers to objectIteratorState, or set
the scan and end pointers from the objectIteratorState.
-Implements getObject() to return pointer to the array.
Created new CopmactSchemeFixupObject method: fixupFlattenedArrayObject,
which allows the gc compacter to copmact flattened arrays using
FlattenedContiguousArrayIterator.
Added ValueTypeTest for flattenedArray compact, using -Xcompactgc
flag.
Signed-off-by: Oussama Saoudi [email protected]