fix: avoid duplicating scanned classes #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezovskyi
commented
Jan 4, 2025
| @@ -49,7 +49,7 @@ public class ResourcePackages { | |||
| /** | |||
| * The RDFs-Classes types mapping. | |||
| */ | |||
| static final Map<String, List<Class<?>>> TYPES_MAPPINGS = new HashMap<>(); | |||
| static final Map<String, Set<Class<?>>> TYPES_MAPPINGS = new HashMap<>(); | |||
There was a problem hiding this comment.
@ben81 please note that the map is not "org.eclipse.lyo.oslc4j.provider.jena.resources.child.ChildAnimal" -> [ChildAnimal.class] but instead "http://locahost:7001/vocabulary/AbstractTypesTest2"->[ChildAnimal.class]. It can happen that you annotate multiple classes with the same @OslcNamespace("http://locahost:7001/vocabulary/")/@OslcResourceShape(title = "AbstractTypesTest2") annotation pair and a collection on the map value is designed to handle this.
|
The fix is good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to Set instead of List for keeping a map of all RDF type URI to POJOs to avoid dupe POJO entries in the map.
Checklist
Issues
Closes #673