Corrected cardinality and range of the oslc_config:acceptedBy property #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezovskyi
reviewed
Oct 30, 2023
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| - Kotlin 1.9.0 is used; `kotlin-stdlib-jdk8` dependency was replaced with `kotlin-stdlib` due to [Kotlin updates](https://kotlinlang.org/docs/whatsnew18.html#updated-jvm-compilation-target). | |||
| - Allow application to reset the oauth token cached within the server, when it deems that it is no longer valid | |||
| - Corrected cardinality and range of the oslc_config:acceptedBy property | |||
There was a problem hiding this comment.
please specify from what to what, eg
from
String[0..1]toResource[0..*]
There was a problem hiding this comment.
also, if it's not a fix for a regression, I think it would make to prefix this with an emoji 🧨 that I usually use for breaking changes.
berezovskyi
reviewed
Oct 30, 2023
| @@ -382,7 +382,7 @@ | |||
| <resourceProperties id="_pnZqcZUdEeq-KoPaR9_Cfg" name="versionId" description="A short human-readable identifier for the version of a resource. All versioned resources should have this property; where the property is present, this identifier must be unique amongst all currently existing versions of the same concept resource. The subject of this property should be the concept resource URI." valueType="String"/> | |||
| <resourceProperties id="_jaBLoBe3Ee2Qoa8h9kRCOQ" name="component" description="The component to which this version belongs. Configuration Management provider should indicate the owning component for each version resource using either this property, or using the membership relationship from the component LDPC." valueType="Resource" range="_BrY_wBe1Ee2Qoa8h9kRCOQ"/> | |||
| <resourceProperties id="_Idof4BfGEe2Qoa8h9kRCOQ" name="configurations" valueType="Resource" range="_jaDA0Re3Ee2Qoa8h9kRCOQ"/> | |||
| <resourceProperties id="_fSwgsBfKEe2Qoa8h9kRCOQ" name="acceptedBy" occurs="zeroOrOne" valueType="String" range="_poyKgJUdEeq-KoPaR9_Cfg"/> | |||
| <resourceProperties id="_fSwgsBfKEe2Qoa8h9kRCOQ" name="acceptedBy" occurs="zeroOrMany" valueType="Resource" range="_poyKgJUdEeq-KoPaR9_Cfg"/> | |||
There was a problem hiding this comment.
Kinda breaking change. How did our code work before? Or is this a fix for a regression?
berezovskyi
requested changes
Oct 30, 2023
|
You are correct @berezovskyi but practically I don't believe many/any people have used these config domains, so we can afford to "break" them? |
berezovskyi
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected cardinality and range of the oslc_config:acceptedBy property
Checklist