Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not require auth on CORS preflights #283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Do not require auth on CORS preflights #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f3b1d
fix: do not require auth on CORS preflights
berezovskyi Oct 5, 2024
221c4dd
Merge branch 'master' into b-cors
berezovskyi Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...odegenerator/src/org/eclipse/lyo/oslc4j/codegenerator/files/generateCredentialsFilter.mtl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,27 @@ public class [anAdaptorInterface.javaClassNameForCredentialsFilter() /] implemen
* @return true - the resource is protected, otherwise false
*/
private boolean isProtectedResource(HttpServletRequest httpRequest) {
if (ignoreResourceProtection) {
return false;
}
String pathInfo = httpRequest.getPathInfo();

//'protectedResource' defines the basic set of requests that needs to be protected.
//You can override this defintion in the user protected code block below.
// Do not protect OSLC resources needed for initial discovery
boolean protectedResource = !pathInfo.startsWith("/rootservices") && !pathInfo.startsWith("/oauth");
// Do not protect CORS preflight requests
if (protectedResource) {
String method = httpRequest.getMethod();
if ("OPTIONS".equalsIgnoreCase(method)) {
protectedResource = false;
}
}
// Only for debugging!
if (ignoreResourceProtection) {
protectedResource = false;
}
// Here you can override or extend the checks
// [protected ('isProtectedResource')]
// [/protected]

return protectedResource;
}

Expand Down