Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boostrap update to v4.2 #228

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Boostrap update to v4.2 #228

merged 3 commits into from
Feb 10, 2022

Conversation

berezovskyi
Copy link
Contributor

  1. Update from Bootstrap 4.0.0-beta to 4.2.1 (not all the way to 4.6 due to popovers no longer work with bootstrap 4.3 #227).
  2. Stop bundling the JS and remove old templates.
  3. Extract bootstrap tags into a public template fragment org::eclipse::lyo::oslc4j::codegenerator::staticFiles::generateCssAndJsFiles.
  4. Display site title with the class navbar-brand
  5. Fix the closing div tag that caused a broken footer on the SP page.

Screen Shot 2022-02-10 at 03 38 46

Screen Shot 2022-02-10 at 03 38 42

@berezovskyi
Boostrap update
a48f186 
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi
Revert to bootstrap 4.2 due to #227
c563515 
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi
update version notice
7a5050f 
Signed-off-by: Andrew Berezovskyi <[email protected]>
@berezovskyi berezovskyi added Type: Bug Something isn't working Type: Enhancement New feature or request Type: Maintenance labels Feb 10, 2022
@berezovskyi
Copy link
Contributor Author

I was not able to figure out where generateGetResourceJsp.mtl is used.

This was referenced Feb 10, 2022
Merged
Open
@jadelkhoury jadelkhoury merged commit ddb03d0 into master Feb 10, 2022
@berezovskyi berezovskyi deleted the bootstrap-4.6 branch March 7, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadelkhoury jadelkhoury jadelkhoury approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berezovskyi @jadelkhoury