Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LSP rename handler for Java file #494

Closed

Conversation

angelozerr
Copy link
Contributor

This PR disable LSP rename handler for Java file.

The problem has been reported here jbosstools/jbosstools-quarkus#199

The JBoss Quarkus maps the MicroProfile language server to a Java file. Once the plugin is installed, it is not possible to use Alt+Shift+R because I think there is a conflict between LSP4E and JDT which is really annoying.

I have never seen some language server which support rename in Java file, it is the reason why this PR disable rename handler for Java file.

@angelozerr angelozerr force-pushed the disable-rename-for-java branch 2 times, most recently from 7087ee3 to 4021915 Compare February 28, 2023 08:58
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't create a particular dependency in LSP4E between LSP4E and JDT. We need to find another solution.

@angelozerr
Copy link
Contributor Author

This problem is very annoying because when you install JBoss Quarkus, we loose the capability to use Alt+Shift+R in Java editor.

Instead of excluding JDT Java source, we could include only editor which is the generic editor. What do you think @mickaelistria ?

@sbouchet
Copy link

sbouchet commented Mar 1, 2023

see also #38

@mickaelistria
Copy link
Contributor

I'm closing this in LSP4E, it's more properly actionable on JDT end: eclipse-platform/eclipse.platform.ui#513 (comment) , or even in the jbosstools-quarkus plugin to redefine the binding to force one over the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants