High CPU usage and memory consumption even if doing nothing #3196

snjeza · 2024-06-17T16:17:58Z

snjeza · 2024-06-17T17:15:04Z

test this please

rgrunber

It definitely seems to be consistently halting the build after about 6 or so build jobs (for openjdk/ , do you know why there's multiple?)

I'm seeing now in the logs :

!ENTRY org.eclipse.jdt.apt.pluggable.core 4 1 2024-06-18 15:45:20.369
!MESSAGE Exception thrown by Java annotation processor org.netbeans.modules.openide.util.ServiceProviderProcessor@4ca43248
!STACK 0
java.lang.Exception: java.lang.IllegalArgumentException: Unsupported location: SOURCE_PATH
	at org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:171)
	at org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.round(RoundDispatcher.java:123)
	at org.eclipse.jdt.internal.compiler.apt.dispatch.BaseAnnotationProcessorManager.processAnnotations(BaseAnnotationProcessorManager.java:172)
	at org.eclipse.jdt.internal.apt.pluggable.core.dispatch.IdeAnnotationProcessorManager.processAnnotations(IdeAnnotationProcessorManager.java:134)
	at org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:952)
	at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:449)
	at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:425)
	at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:410)
	at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.compile(BatchImageBuilder.java:211)
	at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:341)
	at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.build(BatchImageBuilder.java:79)
	at org.eclipse.jdt.internal.core.builder.JavaBuilder.buildAll(JavaBuilder.java:286)
	at org.eclipse.jdt.internal.core.builder.JavaBuilder.build(JavaBuilder.java:192)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:1077)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:296)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:352)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:441)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:444)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:555)
	at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:503)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:585)
	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:207)
	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:300)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.lang.IllegalArgumentException: Unsupported location: SOURCE_PATH
	at org.eclipse.jdt.internal.apt.pluggable.core.filer.IdeFilerImpl.getFileFromOutputLocation(IdeFilerImpl.java:236)
	at org.eclipse.jdt.internal.apt.pluggable.core.filer.IdeFilerImpl.getResource(IdeFilerImpl.java:204)
	at org.openide.util.lookup.implspi.AbstractServiceProviderProcessor.registerImpl(AbstractServiceProviderProcessor.java:199)
	at org.openide.util.lookup.implspi.AbstractServiceProviderProcessor.register(AbstractServiceProviderProcessor.java:159)
	at org.netbeans.modules.openide.util.ServiceProviderProcessor.register(ServiceProviderProcessor.java:81)
	at org.netbeans.modules.openide.util.ServiceProviderProcessor.handleProcess(ServiceProviderProcessor.java:61)
	at org.openide.util.lookup.implspi.AbstractServiceProviderProcessor.process(AbstractServiceProviderProcessor.java:103)
	at org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:141)
	... 25 more

With that said this seems to improve things. I would just rename the commit message to something like :

"Ensure every null analysis annotation has a value defined when enabled."

Signed-off-by: Snjezana Peco <[email protected]>

snjeza · 2024-06-18T20:35:46Z

With that said this seems to improve things. I would just rename the commit message to something like :
"Ensure every null analysis annotation has a value defined when enabled."

I have renamed it.

snjeza · 2024-06-19T03:21:09Z

It definitely seems to be consistently halting the build after about 6 or so build jobs (for openjdk/ , do you know why there's multiple?)

JDT will start the build job again and again, forever.

You can try to set a breakpoint at

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceEventsHandler.java

Line 110 in 22931df

CHANGE_TYPE changeType = toChangeType(fileEvent.getType());

or
https://github.com/eclipse-platform/eclipse.platform/blob/a5bbdf49ef8c0741c380739169771b860ba35ce1/resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/events/AutoBuildJob.java#L207

This PR fixes the issue.

rgrunber · 2024-06-19T03:36:00Z

Yes, it builds forever without your change, but with it, there are still some build jobs that run according to the server status bar. It looks like :

cfbc2da3 Importing Maven project(s) [Done]
14f9b052 Synchronizing projects [Done]
63eec92a LookupJDKToolchainsJob [Done]
7da408a1 Synchronizing projects [Done]
39f42377 Validate documents [Done]
c8fa0941 Publish Diagnostics [Done]
2b3080a9 Building [Done]
8d3a0eaf Building [Done]
9b36ec88 Building [Done]
30a495ff Building [Done]
c545e4e9 Building [Done]
ee516b47 Building [Done]
0fe881a2 Building [Done]
bad6de7f Building [Done]
f4c4fcd1 Building [Done]
f2938d1b Building [Done]

It does in fact stop there. Just wondering why there are that many.

snjeza · 2024-06-19T03:38:24Z

I'm seeing now in the logs :

I have seen it, too, when setting "java.compile.nullAnalysis.mode": "disabled".
It is another issue. org.netbeans.modules.openide.util.ServiceProviderProcessor throws this exception. It doesn't cause a high CPU usage.

snjeza · 2024-06-19T03:47:11Z

there are still some build jobs that run according to the server status bar...
It does in fact stop there. Just wondering why there are that many.

Eclipse platform starts the build job for different events mostly when a watched file changes.
An annotation processor probably causes it.

tonyrusignuolo · 2024-10-02T16:34:20Z

This is killing me. Every workspace I create defaults to java.compile.nullAnalysis.mode: interactive and crashes my remotes. I just created a machine with 32 cores and 128 GBs of ram and this eats all of that every time I start a new workspace. Can I get some help disabling or limiting that?

snjeza · 2024-10-02T17:25:54Z

@tonyrusignuolo Have you a project example reproducing the issue?

tonyrusignuolo · 2024-10-02T17:44:59Z

I'm mostly using this at work, so I can't share the code. But this happens with every Java project I open even if I set the User setting to "disabled". Each new workspace opens with the default setting as "interactive" and it crushes all my processing and ram

tonyrusignuolo · 2024-10-02T19:04:32Z

Is it possible to set this to disabled by default?
Or put a default limit on compute, ram, repeated processes? Like 100% utilization on 32 cores and 128 GBs is nuts

snjeza · 2024-10-02T20:13:45Z

Every workspace I create defaults to java.compile.nullAnalysis.mode: interactive and crashes my remote

I suppose it isn't related to java.compile.nullAnalysis.mode. Could you attach a log? - Enble logging

snjeza requested review from fbricon, mickaelistria, rgrunber, jdneo, testforstephen and CsCherrYY June 17, 2024 16:17

rgrunber added this to the End June 2024 milestone Jun 18, 2024

rgrunber added bug performance labels Jun 18, 2024

rgrunber reviewed Jun 18, 2024

View reviewed changes

Ensure every null analysis annotation has a value defined when enabled

ad0245f

Signed-off-by: Snjezana Peco <[email protected]>

snjeza force-pushed the issue-3387 branch from 48fb47c to ad0245f Compare June 18, 2024 20:33

rgrunber merged commit 8d06711 into eclipse-jdtls:master Jun 19, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

High CPU usage and memory consumption even if doing nothing #3196

High CPU usage and memory consumption even if doing nothing #3196

snjeza commented Jun 17, 2024

snjeza commented Jun 17, 2024

rgrunber left a comment •

edited

Loading

snjeza commented Jun 18, 2024

snjeza commented Jun 19, 2024

rgrunber commented Jun 19, 2024 •

edited

Loading

snjeza commented Jun 19, 2024

snjeza commented Jun 19, 2024

tonyrusignuolo commented Oct 2, 2024

snjeza commented Oct 2, 2024

tonyrusignuolo commented Oct 2, 2024 •

edited

Loading

tonyrusignuolo commented Oct 2, 2024

snjeza commented Oct 2, 2024

High CPU usage and memory consumption even if doing nothing #3196

High CPU usage and memory consumption even if doing nothing #3196

Conversation

snjeza commented Jun 17, 2024

snjeza commented Jun 17, 2024

rgrunber left a comment • edited Loading

Choose a reason for hiding this comment

snjeza commented Jun 18, 2024

snjeza commented Jun 19, 2024

rgrunber commented Jun 19, 2024 • edited Loading

snjeza commented Jun 19, 2024

snjeza commented Jun 19, 2024

tonyrusignuolo commented Oct 2, 2024

snjeza commented Oct 2, 2024

tonyrusignuolo commented Oct 2, 2024 • edited Loading

tonyrusignuolo commented Oct 2, 2024

snjeza commented Oct 2, 2024

rgrunber left a comment •

edited

Loading

rgrunber commented Jun 19, 2024 •

edited

Loading

tonyrusignuolo commented Oct 2, 2024 •

edited

Loading