-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container support for freyja_apps #9
Container support for freyja_apps #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments. Please take a look.
freyja_apps/ibeji_adapter/Cargo.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope for this PR but something we should think about: we're starting to just go through permutations of adapters in this repo. It might be valuable to find a way to have a single app here that selects adapters based on config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though this would likely mean all of the adapters have to be statically linked, which is less than ideal
The Alex Recommends workflow doesn't work for forks so we're okay to check in without that passing since it's doing non-functional checks. I am going to do the cargo update to fix the security audit now to resolve that workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
This PR adds container support for Example Freyja applications. This PR does the following:
Validated that the containers work with Podman and Docker and can communicate with Ibeji and the mixed sample provider.