Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container support for freyja_apps #9

Merged
merged 12 commits into from
Oct 27, 2023

Conversation

devkelley
Copy link
Contributor

This PR adds container support for Example Freyja applications. This PR does the following:

  • Add an ibeji-adapter freyja example application that connects with Ibeji but does not communicate with the cloud.
  • Adds Dockerfile.freyja_apps that will be used by any Example Freyja Applications to containerize them.
    • The dockerfile defaults to the in-memory example application.
  • Updates the ibeji-adapter to allow for containerization with outbound requests to localhost using a DNS alias.
  • Add how to run in a container to README files for supported example applications.
  • Add .env files for containers.
  • Add README explaining what Dockerfile to use in the new container folder.

Validated that the containers work with Podman and Docker and can communicate with Ibeji and the mixed sample provider.

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. Please take a look.

Dockerfile.freyja_apps Outdated Show resolved Hide resolved
freyja_adapters/digital_twin/ibeji_adapter/src/config.rs Outdated Show resolved Hide resolved
freyja_apps/ibeji_adapter/README.md Show resolved Hide resolved
freyja_apps/ibeji_adapter/README.md Outdated Show resolved Hide resolved
Dockerfile.freyja_apps Show resolved Hide resolved
freyja_apps/ibeji_adapter/README.md Show resolved Hide resolved
freyja_apps/ibeji_adapter/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope for this PR but something we should think about: we're starting to just go through permutations of adapters in this repo. It might be valuable to find a way to have a single app here that selects adapters based on config

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though this would likely mean all of the adapters have to be statically linked, which is less than ideal

wilyle
wilyle previously approved these changes Oct 27, 2023
@wilyle
Copy link
Contributor

wilyle commented Oct 27, 2023

The Alex Recommends workflow doesn't work for forks so we're okay to check in without that passing since it's doing non-functional checks. I am going to do the cargo update to fix the security audit now to resolve that workflow

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit 758a61d into eclipse-ibeji:main Oct 27, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants