Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration for example Freyja adapters #7

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Sep 29, 2023

Improve configuration for example Freyja adapters by applying the same config strategy that's used for the mocks in the main repo. Also fixes a notice generation issue.

Fixes #4

@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit 520cf81 into main Sep 29, 2023
11 checks passed
@wilyle wilyle deleted the wilyle/config-upd branch September 29, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Improve Configuration at Runtime
2 participants