Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve and build protobuf from remote URLs #63

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Retrieve and build protobuf from remote URLs #63

merged 3 commits into from
Mar 25, 2024

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Mar 25, 2024

Currently, this project is using cargo git dependencies to reference the proto packages from other ESDV projects such as Freyja. This has caused compatibility issues and needs to be updated. This PR makes a change to pull the content from a remote URL and build the proto files within the repo. Inspired by UProtocol: https://github.com/eclipse-uprotocol/up-rust/blob/main/build.rs

Fixes #59

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Please take a look.

proto/common/src/lib.rs Show resolved Hide resolved
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wilyle wilyle merged commit 1c44ac1 into main Mar 25, 2024
11 checks passed
@wilyle wilyle deleted the wilyle/proto branch March 25, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Retrieve and build protobuf from remote URLs
2 participants