Remove C# Cloud Connector and Restructure cloud_connectors directory
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
wilyle
changed the title
cloud_connectors directory
jorchiu
reviewed
Mar 25, 2024
ashbeitz
reviewed
Mar 25, 2024
cloud_connectors/resources/scripts/digital_twins_setup_smart_trailer.sh
Outdated
Show resolved
Hide resolved
2 tasks
jorchiu
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the C# cloud connector in favor of the MQTT Cloud Connector. The C# Connector was an interim sample intended for a basic demo scenario, but the MQTT sample is now preferred for end-to-end sample scenarios. This PR consists of the following changes:
cloud_connectors/azure/README.md,cloud_connectors/azure/sample_dtdl/README.md, andcloud_connectors/azure/mqtt_connector/README.mdfile into thecloud_connectors/mqtt_connector/README.mdfilecloud_connectorsdirectory so that it's organized more intuitively now that the above content is removed:azuredirectory from the hierarchy since the connector is not Azure-specificresourcesdirectory instead of being nested inside the MQTT connector source codeazuredirectory into theresourcesdirectory. This includes scripts and sample DTDL files.sample-dtdldirectory tosample_dtdlto be consistent about directory naming conventions