Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Ibeji Adapter from Freyja repo #5

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Migrate Ibeji Adapter from Freyja repo #5

merged 6 commits into from
Sep 29, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Sep 28, 2023

Migrates the IbejiAdapter from the Freyja repo and makes updates as necessary

@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

@wilyle
Copy link
Contributor Author

wilyle commented Sep 28, 2023 •
edited
Loading

This PR directly copies the IbejiAdapter from Freyja and only makes changes that are necessary to build and run properly with the latest version of Freyja. Other updates (such as config improvements as described in #4 ) will be made in future PRs

ashbeitz
ashbeitz reviewed Sep 29, 2023
View reviewed changes
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

freyja_adapters/digital_twin/ibeji_adapter/README.md Outdated Show resolved Hide resolved
freyja_adapters/digital_twin/ibeji_adapter/README.md Show resolved Hide resolved
ashbeitz
ashbeitz approved these changes Sep 29, 2023
View reviewed changes
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@wilyle wilyle merged commit a0ed63a into main Sep 29, 2023
11 checks passed
@wilyle wilyle deleted the wilyle/ibeji-adapter branch January 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashbeitz ashbeitz ashbeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilyle @ashbeitz