Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update Dockerfiles for arm64 support and documentation #23

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

devkelley
Copy link
Contributor

@devkelley devkelley commented Dec 6, 2023

This PR does the following:

  • Add Dockerfiles for arm64 support
  • Add Dockerfiles to build the azure digital twins cloud connector
  • Remove containerize feature
  • Updated the container README.md doc to explain how to build and run containers for Docker and Podman
  • Reference containers.md in multiple READMEs
  • removed global.json as it was causing issues with building the containers.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Please take a look.

container/README.md Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
ashbeitz
ashbeitz previously approved these changes Dec 6, 2023
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@devkelley devkelley merged commit c858dc6 into main Dec 7, 2023
14 checks passed
@wilyle wilyle deleted the devkelley/add_azure_cloud_connector_container branch January 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants