Fix pause of rollout on error condition #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TRS1SF3 <[email protected]>
|
Can one of the admins verify this patch? |
denislavprinov
approved these changes
Dec 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following case :
During rollout processing (which is ran in a transaction per rollout) all rollout groups are being processed one by one
if a group matches error condition - group status goes to error and rollout is being paused.
But
If previous group have matched error condition and paused the rollout
and the current one matches also the error condition and tries to pause the rollout too - this will throw an exception because rollout is already in paused state and will rollback the rollout processing transaction which will lead us on initial state.