Skip to content

Commit

Permalink
Fix lombok issues (#2079)
Browse files Browse the repository at this point in the history
Signed-off-by: Avgustin Marinov <[email protected]>
  • Loading branch information
avgustinmm authored Nov 18, 2024
1 parent 00fe507 commit 7ac0a13
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@

import java.io.Serial;

import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.ToString;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Sort;

Expand All @@ -22,7 +24,9 @@
* the REST-API is working with {@code offset} and {@code limit} parameter we
* need an offset based page request.
*/
@Data
@Getter
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public final class OffsetBasedPageRequest extends PageRequest {

@Serial
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@
import java.util.Collections;
import java.util.List;

import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.ToString;

/**
* A bean which holds a complex result of an service operation to combine the
* information of an assignment and how much of the assignment has been done and
* how much of the assignments had already been existed.
* A bean which holds a complex result of a service operation to combine the information of an assignment and how much of the assignment
* has been done and how much of the assignments had already been existed.
*/
@Data
@Getter
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public class DistributionSetAssignmentResult extends AbstractAssignmentResult<Action> {

private final DistributionSet distributionSet;
Expand All @@ -28,7 +31,7 @@ public class DistributionSetAssignmentResult extends AbstractAssignmentResult<Ac
* Constructor.
*
* @param distributionSet that has been assigned
* @param alreadyAssigned the the count of already assigned targets
* @param alreadyAssigned the count of already assigned targets
* @param assigned the assigned actions
*/
public DistributionSetAssignmentResult(final DistributionSet distributionSet, final int alreadyAssigned,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,19 @@

import java.util.List;

import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.ToString;

/**
* Result object for {@link DistributionSetTag} assignments.
*
* @deprecated since 0.6.0 with toggle deprecation
*/
@Deprecated(forRemoval = true, since = "0.6.0")
@Data
@Getter
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public class DistributionSetTagAssignmentResult extends AbstractAssignmentResult<DistributionSet> {

private final DistributionSetTag distributionSetTag;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,19 @@

import java.util.List;

import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.ToString;

/**
* Result object for {@link TargetTag} assignments.
*
* @deprecated since 0.6.0 with deprecation of toggle assignments
*/
@Deprecated(forRemoval = true, since = "0.6.0")
@Data
@Getter
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public class TargetTagAssignmentResult extends AbstractAssignmentResult<Target> {

private final TargetTag targetTag;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,16 @@

import java.util.List;

import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.ToString;

/**
* Result object for {@link TargetType} assignments.
*/
@Data
@Getter
@EqualsAndHashCode(callSuper = true)
@ToString(callSuper = true)
public class TargetTypeAssignmentResult extends AbstractAssignmentResult<Target> {

private final TargetType targetType;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,7 @@ public interface BaseEntityRepository<T extends AbstractJpaTenantAwareBaseEntity
@Override
List<T> findAllById(final Iterable<Long> ids);

// TODO When we switch to Spring 3.0 probably we could remove extending methods using
// queries and make here a default implementation using JPASpecificationExecutor delete method
// TODO To be considered if this method is needed at all

/**
* Deletes all entities of a given tenant from this repository. For safety
* reasons (this is a "delete everything" query after all) we add the tenant
Expand Down

0 comments on commit 7ac0a13

Please sign in to comment.