Fix ACM DS test (#1900)

Signed-off-by: Marinov Avgustin <[email protected]>
eclipse-hawkbit · Oct 17, 2024 · 331cf8e · 331cf8e
1 parent b48a50e
commit 331cf8e
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/...rg/eclipse/hawkbit/repository/jpa/acm/controller/DistributionSetAccessControllerTest.java b/...rg/eclipse/hawkbit/repository/jpa/acm/controller/DistributionSetAccessControllerTest.java
@@ -191,6 +191,7 @@ void verifyTagFilteringAndManagement() {
         final DistributionSet readOnly = testdataFactory.createDistributionSet();
         final DistributionSet hidden = testdataFactory.createDistributionSet();
         final DistributionSetTag dsTag = distributionSetTagManagement.create(entityFactory.tag().create().name("dsTag"));
+        final DistributionSetTag dsTag2 = distributionSetTagManagement.create(entityFactory.tag().create().name("dsTag2"));
 
         // perform tag assignment before setting access rules
         distributionSetManagement.assignTag(Arrays.asList(permitted.getId(), readOnly.getId(), hidden.getId()),
@@ -230,16 +231,12 @@ void verifyTagFilteringAndManagement() {
                 .isInstanceOf(InsufficientPermissionException.class);
 
         // assignment is denied for readOnlyTarget (read, but no update permissions)
+        // dsTag2- since - it is tagged with dsTag and won't do anything if assigning dsTag
         assertThatThrownBy(() -> {
-            distributionSetManagement.assignTag(Collections.singletonList(readOnly.getId()), dsTag.getId());
+            distributionSetManagement.assignTag(Collections.singletonList(readOnly.getId()), dsTag2.getId());
         }).as("Missing update permissions for target to toggle tag assignment.")
                 .isInstanceOf(InsufficientPermissionException.class);
 
-        // assignment is denied for readOnlyTarget (read, but no update permissions)
-        assertThatThrownBy(() -> distributionSetManagement.unassignTag(List.of(readOnly.getId()), dsTag.getId()))
-                .as("Missing update permissions for target to toggle tag assignment.")
-                .isInstanceOf(InsufficientPermissionException.class);
-
         // assignment is denied for hiddenTarget since it's hidden
         assertThatThrownBy(() -> distributionSetManagement.unassignTag(Collections.singletonList(hidden.getId()), dsTag.getId()))
                 .as("Missing update permissions for target to toggle tag assignment.")