Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SAMM meta model class for units #36

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

Hanna-Shalamitskaya-EPAM
Copy link
Contributor

@Hanna-Shalamitskaya-EPAM Hanna-Shalamitskaya-EPAM commented May 23, 2024

Description

Changes:

  • Added SAMM meta model module;
  • Created SammUnitsGraph class for getting access to the parameter units;
  • Added unit tests for the SammUnitsGraph class.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@@ -63,3 +63,29 @@ This script can be executed with
poetry run download-samm-branch
```
to download and start working with the Aspect Model Loader.

## SAMM meta model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## SAMM meta model
## Semantic Aspect Meta Model


## SAMM meta model

To be able to use "SAMM meta model" classes you need to download "SAMM Aspect Meta Model for development" ([Set Up SAMM Aspect Meta Model for development](#Set Up SAMM Aspect Meta Model for development)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To be able to use "SAMM meta model" classes you need to download "SAMM Aspect Meta Model for development" ([Set Up SAMM Aspect Meta Model for development](#Set Up SAMM Aspect Meta Model for development)).
To be able to use SAMM meta model classes you need to download the corresponding files. Details are described in [Set up SAMM Aspect Meta Model for development](#set-up-samm-aspect-meta-model-for-development).


To be able to use "SAMM meta model" classes you need to download "SAMM Aspect Meta Model for development" ([Set Up SAMM Aspect Meta Model for development](#Set Up SAMM Aspect Meta Model for development)).

This module contains classes for working with SAMM data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module contains classes for working with SAMM data.
This module contains classes for working with Aspect data.

@atextor atextor merged commit e0d251b into eclipse-esmf:main Jun 5, 2024
2 checks passed
@atextor atextor deleted the add_get_units_function branch June 5, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants