Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SAMM 2.1.0 version #16

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Support SAMM 2.1.0 version #16

merged 2 commits into from
Oct 10, 2023

Conversation

Hanna-Shalamitskaya-EPAM
Copy link
Contributor

@Hanna-Shalamitskaya-EPAM Hanna-Shalamitskaya-EPAM commented Oct 6, 2023 •
edited
Loading

Changes:

  • Was updated test ttl models to SAMM 2.1.0;
  • Was updated integration tests;
  • Was changed Either (removed data_type attribute).

atextor
atextor requested changes Oct 9, 2023
View reviewed changes
core/esmf-aspect-meta-model-python/tests/integration/test_subclasses.py Outdated
@@ -118,12 +117,12 @@
List,
Set,
SortedSet,
SortedSet,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated line intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Yauhenikapl
Yauhenikapl approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but need to fix comment by Andreas

@atextor atextor merged commit 0c1663c into eclipse-esmf:main Oct 10, 2023
1 check passed
@atextor atextor deleted the rbs-11581-support-samm-2-1-0 branch October 10, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

@atextor atextor atextor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hanna-Shalamitskaya-EPAM @atextor @Yauhenikapl