Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use convenience factory methods for collections #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use convenience factory methods for collections #143

wants to merge 1 commit into from

Conversation

marschall
Copy link
Contributor

Use convenience factory methods for collections instead of double brace initialization.

@marschall
Use convenience factory methods for collections
811b763 
Use convenience factory methods for collections instead of double brace initialization.
@marschall
Copy link
Contributor Author

Convenience factory methods were added with JEP-269 in Java 9. Since our tests are Java 9 and the only users are Java 9 this should not be an issue.

Double brace initialization is generally frowned upon

jbescos
jbescos approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jbescos jbescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbescos jbescos jbescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marschall @jbescos