Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathProvider supports Path entities, in preparation for future default support in JAX-RS 4.1 / Jersey 4.1 #5674

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mkarg
Copy link
Member

@mkarg mkarg commented Jun 8, 2024

Aim

This PR adds support for Path entity types in analogy to the existing support for File entity types.

Justification

In an attempt to modernize JAX-RS and better align it with modern Java, I soon will file a PR for Jakarta REST 4.1 to natively support Path entity types by all compliant implementations. As an existing implementation is needed before making an API change part of the specification and TCK, I kindly ask to adopt this new feature to Jersey 3.1 already (as it is optional and non-breaking).

Description

This PR only adds optional support for Path, not making it part of MessagingBinders as it is not yet a mandatory element of the JAX-RS specification, neither in 3.x nor 4.0. In a subsequent PR on the 4.x branch I will later add PathProvider to MessagingBinders when agreed to make it part of JAX-RS 4.1.

@mkarg
Copy link
Member Author

mkarg commented Jun 8, 2024

@jansupol Kindly asking for adoption of this optional feature to Jersey 3.1.8 and Jersey 4.0, so we have an existing technical base to decide adoption of Path entity type in JAX-RS 4.1. Thank you! :-)

@mkarg mkarg force-pushed the PathProvider branch 4 times, most recently from 924c585 to 6382438 Compare June 8, 2024 21:16
@mkarg
Copy link
Member Author

mkarg commented Jun 9, 2024

@jansupol Jenkins says that all tests run fine on JDK 21, but on JDK 11 fails with the below message. I doubt that it is caused by my changes / this PR. But how to proceed now?

BroadcasterExecutorTest.test:177 Client event called from wrong thread ( ) ==> expected: but was:

…t support in JAX-RS 4.x / Jersey 4.x.

Signed-off-by: Markus KARG <[email protected]>
Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mkarg

Copy link
Contributor

@senivam senivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol jansupol merged commit a31c9ae into eclipse-ee4j:3.1 Jul 2, 2024
6 of 7 checks passed
@mkarg mkarg deleted the PathProvider branch July 5, 2024 22:16
@mkarg
Copy link
Member Author

mkarg commented Jul 6, 2024

Thank you for adopting this into upcomging 3.1.8.

Please find the proposed JAX-RS enhancement proposal here: jakartaee/rest#1274. :-)

@senivam senivam added this to the 3.1.8 milestone Jul 16, 2024
@mkarg
Copy link
Member Author

mkarg commented Jul 27, 2024

Kindly asking your vote for jakartaee/rest#1275. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants