refactor: revisit transfer samples #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidonos
requested review from
jimmarino,
paullatzelsperger and
ronjaquensel
as code owners
# Conflicts: # transfer/transfer-00-prerequisites/connector/build.gradle.kts # transfer/transfer-06-consumer-pull-http/README.md # transfer/transfer-07-provider-push-http/README.md
ndr-brt
requested changes
Oct 26, 2023
system-tests/src/test/java/org/eclipse/edc/samples/transfer/HttpRequestLoggerUtil.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/edc/samples/advanced/advanced00opentelemetry/Advanced00openTelemetryTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| > Before starting with these samples, be sure to check out the [basic](../basic/README.md) and [transfer](../transfer/README.md) samples! | ||
|
|
||
| ## Samples |
There was a problem hiding this comment.
note: Also other/custom-runtime could be moved here, better in a subsequent PR
...va/org/eclipse/edc/samples/advanced/advanced00opentelemetry/Advanced00openTelemetryTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/eclipse/edc/samples/transfer/transfer00prerequisites/PrerequisitesCommon.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/edc/samples/transfer/transfer00prerequisites/Transfer00prerequisitesTest.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/edc/samples/advanced/advanced00opentelemetry/Advanced00openTelemetryTest.java
Outdated
Show resolved
Hide resolved
|
This pull request is stale because it has been open for 7 days with no activity. |
ndr-brt
requested changes
Nov 6, 2023
system-tests/src/test/java/org/eclipse/edc/samples/transfer/HttpRequestLoggerUtil.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Nov 6, 2023
system-tests/src/test/java/org/eclipse/edc/samples/util/HttpRequestLoggerUtil.java
Outdated
Show resolved
Hide resolved
majadlymhmd
pushed a commit
to FraunhoferISST/edc-samples
that referenced
this pull request
Nov 20, 2023
* extracting negotiation tests * implementing Transfer02consumerPullTest * implementing Transfer03providerPushTest.java * implementing Transfer04eventConsumerTest.java * moving open telemetry to 'advanced' directory * reworking download of open telemetry jar inside gradle build file * checkStyle fixes * fix: clean up and merge * fix: added libs.edc.control.plane.api to build file * fix: fixed event consumer test * fix: resolving pr comments * refactor: move http-request-logger-wrapper.yaml to test directory * refactor: using docker image instead of docker compose for http request logger container * fix: fixing check style issues * fix: removing unnecessary stuff * refactor: removing HttpRequestLoggerUtil.java * fix: setting http-request-logger.jar archiveFilename explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Closes #62