Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing edc-control-plane-api-client dependency #134

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

talele08
Copy link
Contributor

What this PR changes/adds

Add edc-control-plane-api-client to resolve boot issue when running the jar for transfer-06-consumer-pull-http

Why it does that

When running the jar following issues was coming:
org.eclipse.edc.spi.system.injection.EdcInjectionException: The following injected fields were not provided:
Field "transferProcessApiClient" of type [interface org.eclipse.edc.connector.api.client.spi.transferprocess.TransferProcessApiClient] required by org.eclipse.edc.connector.dataplane.framework.DataPlaneFrameworkExtension
To resolve it edc-control-plane-api-client is added as dependency

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@wolf4ood
Copy link
Contributor

Hi @talele08

thanks for this PR. pleas sign the Eclipse ECA

@talele08
Copy link
Contributor Author

Hi @talele08

thanks for this PR. pleas sign the Eclipse ECA

I have signed the Eclipse ECA

@wolf4ood
Copy link
Contributor

@talele08

the check still fails, please verify that the email on commits it's the same you used for the ECA registration

Thanks

@talele08
Copy link
Contributor Author

@talele08

the check still fails, please verify that the email on commits it's the same you used for the ECA registration

Thanks

Thanks for pointing it out. I have resolved it, ECA check is now successful

@ndr-brt ndr-brt added the bug Something isn't working label Oct 11, 2023
@ndr-brt
Copy link
Member

ndr-brt commented Oct 11, 2023

@talele08 you need to give to the PR a name that conforms with the EDC PR etiquette

@ndr-brt ndr-brt self-requested a review October 11, 2023 12:01
@talele08 talele08 changed the title add missing edc-control-plane-api-client dependency fix: add missing edc-control-plane-api-client dependency Oct 12, 2023
@talele08
Copy link
Contributor Author

@talele08 you need to give to the PR a name that conforms with the EDC PR etiquette

I have renamed the PR

@ndr-brt ndr-brt merged commit a3d767b into eclipse-edc:main Oct 12, 2023
7 of 10 checks passed
ndr-brt pushed a commit that referenced this pull request Oct 20, 2023
add missing edc-control-plane-api-client dependency
majadlymhmd pushed a commit to FraunhoferISST/edc-samples that referenced this pull request Nov 20, 2023
…#134)

add missing edc-control-plane-api-client dependency
majadlymhmd pushed a commit to FraunhoferISST/edc-samples that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants