refactor(test): improving EmbeddedRuntime exception handling
#4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Dec 19, 2024
|
|
||
| super.boot(false); | ||
| Thread.currentThread().setContextClassLoader(classLoader); |
There was a problem hiding this comment.
I just saw this now. Technically this should reset the previous classloader for the TCCL in a finally block (on error) or when the runtime shuts down. Probably for another PR.
There was a problem hiding this comment.
It shouldn't be necessary as this code runs in a separated thread, so this classloader assignment is done only for the specific thread
There was a problem hiding this comment.
it's currently working like this:
There was a problem hiding this comment.
Yeah, that could be a problem. Something to fix in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Avoids unnecessary exception wrapping in the
EmbeddedRuntimebootmethodWhy it does that
improve test failure message
Further notes
ConfigurationExtensionthat will load them into aConfigobject directly, more EDC-y :)Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.