-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement own LdpIssuer (replacing Titanium) #3604
feat: implement own LdpIssuer (replacing Titanium) #3604
Conversation
23f549d
to
e6b6558
Compare
e6b6558
to
9ea893e
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3604 +/- ##
==========================================
- Coverage 72.10% 72.06% -0.04%
==========================================
Files 897 898 +1
Lines 17919 17973 +54
Branches 1018 1022 +4
==========================================
+ Hits 12920 12952 +32
- Misses 4562 4580 +18
- Partials 437 441 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok after the doc and formatting comments are addressed
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Outdated
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Outdated
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Outdated
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Show resolved
Hide resolved
...le-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpIssuer.java
Outdated
Show resolved
Hide resolved
ee7bff3
to
539a121
Compare
* feat: implement own LdpIssuer (replacing Titanium) * added monitor, srcdoc, formatting
What this PR changes/adds
This PR adds another, simpler-to-use API for the Issuer part of Titanium. The key aspect is that is uses the EDC expansion/compaction algorithm using the
cached documents.
Why it does that
The Titanium implementation lacks some key aspects, such as adding contexts for SignatureSuites and it is generally cumbersome to use, especially with respect to document caching.
Further notes
IssuerTests
are kept in place for the time being, but they should eventually get deleted.Linked Issue(s)
Links to eclipse-edc/IdentityHub#154
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.