Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement own LdpIssuer (replacing Titanium) #3604

Merged

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Nov 13, 2023

What this PR changes/adds

This PR adds another, simpler-to-use API for the Issuer part of Titanium. The key aspect is that is uses the EDC expansion/compaction algorithm using the
cached documents.

Why it does that

The Titanium implementation lacks some key aspects, such as adding contexts for SignatureSuites and it is generally cumbersome to use, especially with respect to document caching.

Further notes

  • the tests were mostly just copied over, no new tests were added
  • the old IssuerTests are kept in place for the time being, but they should eventually get deleted.
  • no new functionality was added, it was merely refactored.

Linked Issue(s)

Links to eclipse-edc/IdentityHub#154

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a62205b) 72.10% compared to head (539a121) 72.06%.
Report is 1 commits behind head on main.

Files Patch % Lines
...dc/verifiablecredentials/linkeddata/LdpIssuer.java 59.25% 18 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
- Coverage   72.10%   72.06%   -0.04%     
==========================================
  Files         897      898       +1     
  Lines       17919    17973      +54     
  Branches     1018     1022       +4     
==========================================
+ Hits        12920    12952      +32     
- Misses       4562     4580      +18     
- Partials      437      441       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok after the doc and formatting comments are addressed

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Nov 13, 2023
@paullatzelsperger paullatzelsperger merged commit b580bc4 into eclipse-edc:main Nov 14, 2023
16 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/extract_ldp_issuer branch November 14, 2023 07:09
tuncaytunc-zf pushed a commit to tuncaytunc-zf/DataSpaceConnector that referenced this pull request Nov 15, 2023
* feat: implement own LdpIssuer (replacing Titanium)

* added monitor, srcdoc, formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcp enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants