[UD] Make some features togglable, add optional FAQ button #15907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to configure in `product.json` whether to show workspace sharing tab and kubernetes namespace selector or not. Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Signed-off-by: Oleksii Kurinnyi <[email protected]>
akurinnoy
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
|
Can one of the admins verify this patch? |
che-bot
added
status/code-review
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
sleshchenko
approved these changes
Feb 3, 2020
...app/workspaces/workspace-details/workspace-overview/workspace-details-overview.controller.ts
Outdated
Show resolved
Hide resolved
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
[test] |
SkorikSergey
approved these changes
Feb 3, 2020
olexii4
approved these changes
Feb 4, 2020
dashboard/src/components/branding/che-dashboard-configuration.service.ts
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows to configure some UD features to be disabled and hidden. E.g. following configuration disables the kubernetes namespace selector on the create workspace page and on the workspace details page:
{ "configuration": { "features": { "disabled": ["kubernetesNamespaceSelector"] } } }Available values:
"workspaceSharing","kubernetesNamespaceSelector"An URL to the FAQ page is expected to be in "docs" section of
product.json.What issues does this PR fix or reference?
#15462