Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Added ability to disable some menu items and corresponding routes #15777

Merged
merged 3 commits into from
Jan 24, 2020
Merged

[UD] Added ability to disable some menu items and corresponding routes #15777

merged 3 commits into from
Jan 24, 2020

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jan 22, 2020 •
edited
Loading

Signed-off-by: Oleksii Kurinnyi [email protected]

What does this PR do?

This PR introduces ability to configure the User Dashboard. Now it's possible to disable some of menu entries in sidebar by providing configuration in product.json, for example, following configuration disables the Organizations menu item and prevents opening views with list of available organizations or an organization details.

// product.json
{
  "configuration": {
    "menu": {
      "disabled": ["organizations"]
    }
  }
}

What issues does this PR fix or reference?

#15462 (hide Organizations tab)

@akurinnoy
[UD] Added ability to disable some menu items and corresponding routes
c386abe 
User Dashboard can disable some of menu items located in the side bar and corresponding routes.

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy self-assigned this Jan 22, 2020
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jan 22, 2020
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

sleshchenko
sleshchenko reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15462 (hide Organizations tab and disable workspace sharing)

How workspace sharing can be disabled in product.json?

dashboard/README.md Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@akurinnoy
Copy link
Contributor Author

@sleshchenko Good catch! I thought workspace sharing is tightly coupled with organizations but it is not. So I reverted disabling the sharing tab along with organizations as we need a dedicated configuration option to disable sharing tab separately.

(description updated)

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

olexii4
olexii4 reviewed Jan 23, 2020
View reviewed changes
dashboard/src/app/administration/administration-config.ts
import {DockerRegistryList} from './docker-registry/docker-registry-list/docker-registry-list.directive';
import {DockerRegistryListController} from './docker-registry/docker-registry-list/docker-registry-list.controller';
import {EditRegistryController} from './docker-registry/docker-registry-list/edit-registry/edit-registry.controller';

import { AdministrationConfigService } from './administration-config.service';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra spaces

sleshchenko
sleshchenko approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akurinnoy akurinnoy merged commit 80df9d9 into master Jan 24, 2020
@akurinnoy akurinnoy deleted the ud-menu-config branch January 24, 2020 12:16
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 24, 2020
@che-bot che-bot added this to the 7.8.0 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@akurinnoy akurinnoy

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@akurinnoy @che-bot @sleshchenko @olexii4