Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate default value for persistVolumes for clients #15775

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Propagate default value for persistVolumes for clients #15775

merged 1 commit into from
Jan 24, 2020

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Propagate default value for persistVolumes for clients.

It's a lighter version of changes made in #15713 that does not change the current Che Server behavior and at the same time allows us to configure Dashboard behavior via Che Server configuration.
More see #15713 (comment)

What issues does this PR fix or reference?

#15462

Release Notes

N/A

Docs PR

The documentation will be generated from the description of the new property in che.properties

@sleshchenko sleshchenko self-assigned this Jan 22, 2020
@centos-ci
Copy link

Can one of the admins verify this patch?

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jan 22, 2020
sleshchenko
sleshchenko commented Jan 22, 2020
View reviewed changes
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/WorkspaceService.java
@@ -829,6 +833,8 @@ public void deleteProject(
settings.put("cheWorkspaceDevfileRegistryUrl", devfileRegistryUrl);
}

settings.put(CHE_WORKSPACE_PERSIST_VOLUMES_PROPERTY, Boolean.toString(defaultPersistVolumes));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, a dedicated setting property was used for propagating this value but I reverted it 0c81158#diff-3cc9e73374c2afcf0ddf10962bee795bL52
Why? Personally, I can only one prop of using dedicated property - we are able to rename property on Che Server side without affecting REST client.
On another hand, with reusing the same property - users are able to find easily more information about this settings and how it can be configured on the Che Server side.

@sleshchenko sleshchenko mentioned this pull request Jan 22, 2020
Closed
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

amisevsk
amisevsk approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

metlos
metlos approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as providing a default value to clients goes. But shouldn't we also have logic to apply such default value during workspace start in case the client doesn't supply an explicit setting for this?

@artaleks9
Copy link
Contributor

crw-ci-test

@artaleks9
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@artaleks9
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@amisevsk
Copy link
Contributor

But shouldn't we also have logic to apply such default value during workspace start in case the client doesn't supply an explicit setting for this?

I believe the behavior when no setting is provided should be to always provide PVCs, see comment #15713 (comment).

@sleshchenko sleshchenko force-pushed the propagateDefaultPersistVolumeBehaviour_2 branch from 0c81158 to e8d92d6 Compare January 23, 2020 16:23
@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2020

E2E tests of Eclipse Che Multiuser on OCP has failed:

@sleshchenko sleshchenko merged commit a281bc5 into eclipse-che:master Jan 24, 2020
@sleshchenko sleshchenko deleted the propagateDefaultPersistVolumeBehaviour_2 branch January 24, 2020 08:43
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 24, 2020
@che-bot che-bot added this to the 7.8.0 milestone Jan 24, 2020
mshaposhnik pushed a commit that referenced this pull request Jan 27, 2020
@sleshchenko @mshaposhnik
Propagate default value for persistVolumes for clients (#15775)
df8af85 
Signed-off-by: Sergii Leshchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@sparkoo sparkoo sparkoo approved these changes

@metlos metlos metlos approved these changes

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@sleshchenko sleshchenko

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sleshchenko @centos-ci @che-bot @artaleks9 @amisevsk @metlos @sparkoo