-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Docker CLI and images parts of the CLI #13652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Jul 1, 2019
ci-build |
vparfonov
approved these changes
Jul 1, 2019
Fix #13649 move init files used by keycloak and postgres to their folders Change-Id: I66dbb2d6df1f3c062e981a6a513c36be8aa1d39a Signed-off-by: Florent Benoit <[email protected]>
riuvshin
reviewed
Jul 1, 2019
Change-Id: I7ecd663001973706f8bb7ae0ed8a008fdec687a9 Signed-off-by: Florent Benoit <[email protected]>
benoitf
requested review from
dmytro-ndp,
musienko-maxim,
Ohrimenko1988 and
sleshchenko
as code owners
July 1, 2019 13:02
riuvshin
approved these changes
Jul 1, 2019
@musienko-maxim Note that after CLI is removed QA team should stop any CLI based deployments testing and appropriate CI jobs will be removed |
@benoitf I've updated corresponding CI jobs so it can be merged now |
l0rd
approved these changes
Jul 1, 2019
musienko-maxim
approved these changes
Jul 1, 2019
@riuvshin ok I also need to remove all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Remove Docker CLI and images parts of the CLI for Che 7 GA
Fix #13649
move init files used by keycloak and postgres to their folders
Change-Id: I66dbb2d6df1f3c062e981a6a513c36be8aa1d39a
Signed-off-by: Florent Benoit [email protected]
What issues does this PR fix or reference?
#13649