Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker CLI and images parts of the CLI #13652

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Remove Docker CLI and images parts of the CLI #13652

merged 2 commits into from
Jul 1, 2019

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jul 1, 2019

What does this PR do ?

Remove Docker CLI and images parts of the CLI for Che 7 GA
Fix #13649
move init files used by keycloak and postgres to their folders

Change-Id: I66dbb2d6df1f3c062e981a6a513c36be8aa1d39a
Signed-off-by: Florent Benoit [email protected]

What issues does this PR fix or reference?

#13649

@benoitf benoitf requested review from l0rd and vparfonov July 1, 2019 08:55
@benoitf benoitf self-assigned this Jul 1, 2019
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 1, 2019
@benoitf
Copy link
Contributor Author

benoitf commented Jul 1, 2019

ci-build

Fix #13649
move init files used by keycloak and postgres to their folders

Change-Id: I66dbb2d6df1f3c062e981a6a513c36be8aa1d39a
Signed-off-by: Florent Benoit <[email protected]>
Change-Id: I7ecd663001973706f8bb7ae0ed8a008fdec687a9
Signed-off-by: Florent Benoit <[email protected]>
@riuvshin
Copy link
Contributor

riuvshin commented Jul 1, 2019

@musienko-maxim Note that after CLI is removed QA team should stop any CLI based deployments testing and appropriate CI jobs will be removed

@riuvshin
Copy link
Contributor

riuvshin commented Jul 1, 2019

@benoitf I've updated corresponding CI jobs so it can be merged now

@benoitf
Copy link
Contributor Author

benoitf commented Jul 1, 2019

@riuvshin I'm waiting for someone on QA team and @l0rd to give their +1 and we're good to go thx

@benoitf benoitf merged commit 6ebc4c8 into master Jul 1, 2019
@benoitf benoitf deleted the CHE-13649 branch July 1, 2019 14:00
@benoitf
Copy link
Contributor Author

benoitf commented Jul 1, 2019

@riuvshin ok I also need to remove all :nightly and :latest tags from the dockerhub for these images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove docker cli from Che7
6 participants