-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Deployments on OpenShift #1809
Conversation
Signed-off-by: Valeriy Svydenko <[email protected]>
@tolusha it seems externalPluginRegistries parameter was not applied.
Looks like externalPluginRegistries is just ignored, I don't think it's related to this PR |
I've created an issue about externalPluginRegistries eclipse-che/che#22589 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Valeriy Svydenko <[email protected]>
The functionality works properly. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, artaleks9, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Update deployment configuration for Open Shift
What issues does this PR fix or reference?
eclipse-che/che#20133
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.