Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Deployments on OpenShift #1809

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: update Deployments on OpenShift #1809

merged 2 commits into from
Oct 12, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 9, 2023

What does this PR do?

Update deployment configuration for Open Shift

What issues does this PR fix or reference?

eclipse-che/che#20133

How to test this PR?

  1. Login to OS cluster
  2. Execute command from README to deploy che plugin registry:
  oc new-app -f deploy/openshift/che-plugin-registry.yml \
             -p IMAGE="quay.io/eclipse/che-plugin-registry" \
             -p IMAGE_TAG="next" \
             -p PULL_POLICY="Always"
  1. Plugin registry should be deployed and available. In the output you should see a message:
--> Success
    Access your application via route 'che-plugin-registry-pr.apps.rosa.dzhix-cyddx-yrv.1697.p3.openshiftapps.com' 
    Run 'oc status' to view your app.
  1. Try to open route URL from the message and add /v3/plugins at the end
  2. You should see:
    screenshot-che-plugin-registry-pr apps rosa dzhix-cyddx-yrv 1697 p3 openshiftapps com-2023 10 09-18_00_22

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@svor svor requested review from tolusha, artaleks9 and amisevsk October 9, 2023 09:54
@svor svor self-assigned this Oct 9, 2023
@svor svor requested review from vinokurig and ibuziuk as code owners October 9, 2023 09:54
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Click here to review and test in web IDE: Contribute

@tolusha
Copy link
Contributor

tolusha commented Oct 9, 2023

I see the error when try to use the external plugin registry
Screenshot from 2023-10-09 12-53-10

@svor
Copy link
Contributor Author

svor commented Oct 9, 2023

@tolusha it seems externalPluginRegistries parameter was not applied.
I've tried to use next configuration and got the same result as you:

    pluginRegistry:
      disableInternalRegistry: true
      externalPluginRegistries:
        - url: 'https://eclipse-che.github.io/che-plugin-registry/main/'

Looks like externalPluginRegistries is just ignored, I don't think it's related to this PR

@svor
Copy link
Contributor Author

svor commented Oct 9, 2023

I've created an issue about externalPluginRegistries eclipse-che/che#22589

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Valeriy Svydenko <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2023
@artaleks9
Copy link

  • Verified on OpenShift v4.13.1 with
$ oc version
Client Version: 4.11.13
Kustomize Version: v4.5.4
Server Version: 4.13.1

The functionality works properly.

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, artaleks9, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 2ab8f5d into main Oct 12, 2023
11 checks passed
@svor svor deleted the sv-os-deployment branch October 12, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants