-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on timeout #1874
Work on timeout #1874
Conversation
Signed-off-by: Max batleforc <[email protected]>
Signed-off-by: Max batleforc <[email protected]>
Signed-off-by: Max batleforc <[email protected]>
Hi @batleforc. Thanks for your PR. I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: batleforc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Max batleforc <[email protected]>
Signed-off-by: Max batleforc <[email protected]>
@batleforc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Not needed any more with the latest change in devfile/devworkspace-operator#1321 |
What does this PR do?
This pr add a retry to the healhz endpoint injected in the Traefik gateway.
What issues does this PR fix or reference?
eclipse-che/che#23067
How to test this PR?
Start a DevSpaces/Eclipse Che env on an openshift/kubernetes cluster that can take some time to propagate the ip address of the service/pod.
Start a workspace
See that you will wait less than the 5 minute to have the ide showing up when there is some network workload on the cluster.
Prepare a patch file if needed:
OpenShift
on Minikube
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.