Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding a warning about Microsoft's ToS #2833

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Dec 5, 2024

What does this pull request change?

Screenshot 2024-12-09 at 16 44 43

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-4535

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@ibuziuk ibuziuk requested review from deerskindoll and a team as code owners December 5, 2024 11:24
@ibuziuk ibuziuk requested a review from amisevsk December 5, 2024 11:24
Copy link

github-actions bot commented Dec 5, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Dec 5, 2024

🎊 Navigate the preview: https://675ae600789c984e17b8d753--eclipse-che-docs-pr.netlify.app 🎊

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 5, 2024

@deerskindoll please, review
once merged, please backport to 7.95.x for 3.18

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited the warning

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 6, 2024

\retest

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibuziuk ibuziuk merged commit 2124f29 into eclipse-che:main Dec 9, 2024
6 checks passed
@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 9, 2024

@deerskindoll merged, please backport to 7.95.x for 3.18

deerskindoll pushed a commit that referenced this pull request Dec 10, 2024
* docs: Adding a warning about Microsoft's ToS

Signed-off-by: Ilya Buziuk <[email protected]>

* Update modules/administration-guide/pages/configuring-the-open-vsx-registry-url.adoc

---------

Signed-off-by: Ilya Buziuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants