Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuring-a-user-namespace.adoc #2683

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Update configuring-a-user-namespace.adoc #2683

merged 2 commits into from
Feb 14, 2024

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Feb 13, 2024

What does this pull request change?

Removing SSH keys / passwords from the description since it might be misleading

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@ibuziuk ibuziuk requested a review from tolusha February 13, 2024 16:21
@ibuziuk ibuziuk requested review from deerskindoll and a team as code owners February 13, 2024 16:21
Copy link

github-actions bot commented Feb 13, 2024

🎊 Navigate the preview: https://65cb9837ad95480705670a5f--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Feb 13, 2024

Click here to review and test in web IDE: Contribute

@ibuziuk
Copy link
Member Author

ibuziuk commented Feb 13, 2024

@tolusha I'm not sure if we should promote a flow with shared SSH. To avoid confusion I propose to remove it from the docs, and replace with more common credentials wording

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibuziuk ibuziuk merged commit cdc6ce3 into main Feb 14, 2024
10 checks passed
@ibuziuk ibuziuk deleted the ibuziuk-patch-2 branch February 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants