Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Workspace Details page #994

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Rework Workspace Details page #994

merged 1 commit into from
Nov 22, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Nov 17, 2023

What does this PR do?

Openshift
Screenshot 2023-11-17 at 11 40 42

Minikube
Screenshot 2023-11-22 at 10 38 58

What issues does this PR fix or reference?

resolves eclipse-che/che#22612

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy self-assigned this Nov 17, 2023
@che-bot
Copy link
Contributor

che-bot commented Nov 17, 2023

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-994

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e9762d8) 85.17% compared to head (cb364ea) 86.51%.
Report is 6 commits behind head on main.

Files Patch % Lines
...rontend/src/contexts/WorkspaceActions/Provider.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   85.17%   86.51%   +1.34%     
==========================================
  Files         380      379       -1     
  Lines       39198    38875     -323     
  Branches     2521     2546      +25     
==========================================
+ Hits        33388    33634     +246     
+ Misses       5784     5215     -569     
  Partials       26       26              
Flag Coverage Δ
unittests 86.51% <98.98%> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibuziuk
Copy link
Member

ibuziuk commented Nov 21, 2023

@akurinnoy could you please clarify how this functionality would work on minikube?

Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy
Copy link
Contributor Author

@ibuziuk Hi, this is how it works on minikube:
Screenshot 2023-11-22 at 10 38 58

@akurinnoy akurinnoy merged commit 249c8ef into main Nov 22, 2023
12 checks passed
@akurinnoy akurinnoy deleted the rework-workspace-details branch November 22, 2023 08:49
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/402: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/402: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5349 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5350: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5221 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2311: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5350 triggered

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2182: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1577: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4977: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2311 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1577: SUCCESS

3.11.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework "Overview" and remove "DevWorkspace" tab from the "Workspace Details"
5 participants