-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Workspace Details page #994
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-994 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 85.17% 86.51% +1.34%
==========================================
Files 380 379 -1
Lines 39198 38875 -323
Branches 2521 2546 +25
==========================================
+ Hits 33388 33634 +246
+ Misses 5784 5215 -569
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@akurinnoy could you please clarify how this functionality would work on minikube? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ibuziuk Hi, this is how it works on minikube: |
Build 3.11 :: dashboard_3.x/402: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5349: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3736: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5220: dashboard : 3.x :: Build 57129577 : quay.io/devspaces/dashboard-rhel8:3.11-28 |
Build 3.11 :: dashboard_3.x/402: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5349 triggered |
Build 3.11 :: update-digests_3.x/4977: Console, Changes, Git Data |
Build 3.11 :: operator-bundle_3.x/2311: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5350: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3737: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5350: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5221 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.11 :: operator-bundle_3.x/2311: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5350 triggered |
Build 3.11 :: copyIIBsToQuay/2182: Console, Changes, Git Data |
Build 3.11 :: dsc_3.x/1577: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/4977: Detected new images: rebuild operator-bundle |
Build 3.11 :: dsc_3.x/1577: 3.11.0-CI |
What does this PR do?
Openshift
Minikube
What issues does this PR fix or reference?
resolves eclipse-che/che#22612