chore: load all dashboard-related chunks #965
Conversation
|
Click here to review and test in web IDE: |
Signed-off-by: David Kwon <[email protected]>
dkwon17
force-pushed
the
remove-lazy-load
branch
from
10b5e32 to
a698fb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 363 363
Lines 37503 37503
Branches 2444 2440 -4
=======================================
Hits 31768 31768
Misses 5707 5707
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-965 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.10 :: dashboard_3.10/8: Console, Changes, Git Data |
|
Build 3.11 :: dashboard_3.x/380: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5141: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/75: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3567: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.10/41: Console, Changes, Git Data |
|
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5003: dashboard : 3.x :: Build 56641099 : quay.io/devspaces/dashboard-rhel8:3.11-8 |
|
Build 3.11 :: dashboard_3.x/380: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5141 triggered |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.10/74: dashboard : 3.10 :: Build 56641115 : quay.io/devspaces/dashboard-rhel8:3.10-43 |
|
Build 3.11 :: update-digests_3.x/4757: Console, Changes, Git Data |
|
Build 3.10 :: update-digests_3.10/69: Console, Changes, Git Data |
|
Build 3.10 :: dashboard_3.10/8: Upstream sync done; /DS_CI/sync-to-downstream_3.10/75 triggered |
|
Build 3.11 :: operator-bundle_3.x/2240: Console, Changes, Git Data |
|
Build 3.10 :: operator-bundle_3.10/25: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5142: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/77: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3568: Console, Changes, Git Data |
There was a problem hiding this comment.
There was no error message Error: Loading CSS chunk 922 failed. when I followed test scenario from PR description with Eclipse Che Next dashboard deployed from quay.io/eclipse/che-dashboard:pr-965 container image:
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2023.10.31-12_37_29.webm
|
Build 3.10 :: push-latest-container-to-quay_3.10/42: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5142: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5004 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2240: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5142 triggered |
|
Build 3.11 :: copyIIBsToQuay/2040: Console, Changes, Git Data |
|
Build 3.11 :: update-digests_3.x/4757: Detected new images: rebuild operator-bundle |
|
Build 3.11 :: dsc_3.x/1506: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.10/77: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.10/76 triggered; /job/DS_CI/job/dsc_3.10 triggered; |
|
Build 3.10 :: operator-bundle_3.10/25: Upstream sync done; /DS_CI/sync-to-downstream_3.10/77 triggered |
|
Build 3.10 :: copyIIBsToQuay/2041: Console, Changes, Git Data |
|
Build 3.10 :: dsc_3.10/16: Console, Changes, Git Data |
|
Build 3.10 :: update-digests_3.10/69: Detected new images: rebuild operator-bundle |
What does this PR do?
Loads all dashboard UI chunks when accessing the dashboard. This will prevent the user from seeing this error: eclipse-che/che#22230
When comparing to lazy loading, there is a 0.09mb of difference in terms of resource transfer size when loading:
{CHE-HOST}/dashboard/#/create-workspaceLazy loading (left): 3.04mb
No lazy loading (right): 3.15mb
What issues does this PR fix or reference?
eclipse-che/che#22230
Is it tested? How?
{CHE-HOST}/dashboard/#/create-workspaceError: Loading CSS chunk (...) failed.errorlazyload.webm
Release Notes
Docs PR