Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: namespace provision #962

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[cherry-pick] fix: namespace provision #962

merged 1 commit into from
Oct 25, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 25, 2023

cherry-pick of #961

@che-bot
Copy link
Contributor

che-bot commented Oct 25, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <[email protected]>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-962

@dkwon17
Copy link
Contributor

dkwon17 commented Oct 25, 2023

It's working well on my end:

Screencast.from.2023-10-25.10-02-23.webm

@dkwon17
Copy link
Contributor

dkwon17 commented Oct 25, 2023

To verify the PR,

  1. I set my tokenConfig.accessTokenMaxAgeSeconds of my cluster to 60 seconds.
  2. Updated the dashboard image to quay.io/eclipse/che-dashboard:pr-962
  3. Login to the dashboard, and wait for more than 60 seconds
  4. Refresh the page

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Oct 25, 2023

@olexii4: there was no endless refresh page loop in DS 3.10.0.ER-10-24 + Dashboard from image quay.io/eclipse/che-dashboard:pr-962 after access token session had expired:

ds_3 10 0 ER-10-24_plus_che-dashboard_pr-962_image

Screenshot from 2023-10-25 18-24-25

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2023.10.25-19_19_16.webm

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, dmytro-ndp, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 1fe1aac into 7.76.x Oct 25, 2023
9 checks passed
@olexii4 olexii4 deleted the 7.76.x_pr961 branch October 25, 2023 18:51
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.10/5: Console, Changes, Git Data

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants