Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preload data service #948

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: preload data service #948

merged 1 commit into from
Oct 25, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 12, 2023

What does this PR do?

This PR fixed the preload data service and added a test for all bootstrap requests.

What issues does this PR fix or reference?

fixes eclipse-che/che#22479

@che-bot
Copy link
Contributor

che-bot commented Oct 12, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-948

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-948

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-948

Signed-off-by: Oleksii Orel <[email protected]>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-948

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #948 (b80c6ba) into main (9e37924) will increase coverage by 1.87%.
Report is 1 commits behind head on main.
The diff coverage is 75.26%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   82.82%   84.70%   +1.87%     
==========================================
  Files         361      363       +2     
  Lines       37462    37501      +39     
  Branches     2389     2444      +55     
==========================================
+ Hits        31029    31766     +737     
+ Misses       6406     5707     -699     
- Partials       27       28       +1     
Flag Coverage Δ
unittests 84.70% <75.26%> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...dashboard-frontend/src/services/assets/branding.ts 87.50% <100.00%> (+87.50%) ⬆️
...rontend/src/services/axios-wrapper/axiosWrapper.ts 98.26% <100.00%> (ø)
...end/src/services/axios-wrapper/getAxiosInstance.ts 100.00% <100.00%> (ø)
...end/src/services/backend-client/devWorkspaceApi.ts 54.14% <100.00%> (ø)
...services/backend-client/devWorkspaceTemplateApi.ts 44.44% <100.00%> (ø)
...-frontend/src/services/backend-client/eventsApi.ts 100.00% <100.00%> (ø)
...ontend/src/services/backend-client/gitConfigApi.ts 58.82% <100.00%> (ø)
.../services/backend-client/kubernetesNamespaceApi.ts 100.00% <100.00%> (ø)
.../services/backend-client/personalAccessTokenApi.ts 33.80% <100.00%> (ø)
...rd-frontend/src/services/backend-client/podsApi.ts 100.00% <100.00%> (ø)
... and 8 more

... and 8 files with indirect coverage changes

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit ead3ee1 into main Oct 25, 2023
11 of 12 checks passed
@olexii4 olexii4 deleted the CHE-22479 branch October 25, 2023 11:57
@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/375: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/4923: FAILURE

dashboard : 3.x :: Failed in : quay.io/devspaces/dashboard-rhel8:3.11-3
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Preload data service duplicated some requests
5 participants