Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the GettingStarted samples route #920

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix the GettingStarted samples route #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dashboard-backend/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,5 @@ export default async function buildApp(server: FastifyInstance): Promise<void> {

registerPersonalAccessTokenRoutes(server);

registerGettingStartedSamplesRoutes(server);
registerGettingStartedSamplesRoutes(isLocalRun(), server);
}
8 changes: 7 additions & 1 deletion packages/dashboard-backend/src/routes/api/gettingStartedSample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,15 @@ import { getServiceAccountToken } from './helpers/getServiceAccountToken';

const tags = ['Getting Started Samples'];

export function registerGettingStartedSamplesRoutes(instance: FastifyInstance) {
export function registerGettingStartedSamplesRoutes(
isLocalRun: boolean,
instance: FastifyInstance,
) {
instance.register(async server => {
server.get(`${baseApiPath}/getting-started-sample`, getSchema({ tags }), async () => {
if (isLocalRun) {
return [];
}
const token = getServiceAccountToken();
const { gettingStartedSampleApi } = getDevWorkspaceClient(token);
return gettingStartedSampleApi.list();
Expand Down
Loading