Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent preload page bundle from being split #914

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Sep 6, 2023

What does this PR do?

This PR fixes the blank page issue when trying to open the Dashboard using the <CHE-HOST> URL.

What issues does this PR fix or reference?

fixes eclipse-che/che#22476
fixes eclipse-che/che#22478

Is it tested? How?

@che-bot
Copy link
Contributor

che-bot commented Sep 6, 2023

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-914

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 062c292 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akurinnoy akurinnoy merged commit 2af5531 into main Sep 6, 2023
9 checks passed
@akurinnoy akurinnoy deleted the fix-preload branch September 6, 2023 09:21
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/314: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/315: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4181: FAILURE

dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/315: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4351 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants