Full content of the .gitconfig

[akurinnoy]

What does this PR do?

This PR allows displaying the full content of the imported .gitconfig.

Screenshot/screencast of this PR

Screen.Recording.2024-12-05.at.15.55.57.mov

What issues does this PR fix or reference?

resolves eclipse-che/che#23240

Is it tested? How?

see the screencast above

Release Notes

Docs PR

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[che-bot]

Click here to review and test in web IDE:

[codecov]

Codecov Report

Attention: Patch coverage is 97.84483% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (b5e6780) to head (5d55a7c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tend/src/pages/UserPreferences/GitConfig/index.tsx	90.56%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   91.62%   91.48%   -0.14%     
==========================================
  Files         497      499       +2     
  Lines       45480    45651     +171     
  Branches     3181     3162      -19     
==========================================
+ Hits        41669    41762      +93     
- Misses       3778     3855      +77     
- Partials       33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1271

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1271", name: che-dashboard}]}}]"

[olexii4]

I have two feedbacks:

1. I think the "Gitconfig" form should display the whole configuration and have abilities to add and remove values. We have an example of the needed implementation for "Additional Git Remotes"
   

2. I think we should have the same format for the "Gitconfig" viewer that we already have for the "Import Git Configuration"
   

@ibuziuk @akurinnoy WDYT?

[akurinnoy]

/retest

[akurinnoy]

@olexii4 thanks for the review!

I think the "Gitconfig" form should display the whole configuration and have abilities to add and remove values. We have an example of the needed implementation for "Additional Git Remotes"

I agree. Your suggestion is really good and worth implementing as part of another issue. However, the issue only needs to show the full contents of the .gitconfig file, so I decided to do it this way.

I think we should have the same format for the "Gitconfig" viewer that we already have for the "Import Git Configuration"

I'm not sure if I understand "same format" correctly, so please correct me.
If this is about the indentation that gets lost in the config viewer. The library we use to parse/stringify .gitconfig just drops all the indentation. I can handle that, but there may still be some inconsistencies with the original file.
If this is correct, please let me know, so I can add a fix to this PR.

[olexii4]

@olexii4 thanks for the review!

I think the "Gitconfig" form should display the whole configuration and have abilities to add and remove values. We have an example of the needed implementation for "Additional Git Remotes"

I agree. Your suggestion is really good and worth implementing as part of another issue. However, the issue only needs to show the full contents of the .gitconfig file, so I decided to do it this way.

I think we should have the same format for the "Gitconfig" viewer that we already have for the "Import Git Configuration"

I'm not sure if I understand "same format" correctly, so please correct me. If this is about the indentation that gets lost in the config viewer. The library we use to parse/stringify .gitconfig just drops all the indentation. I can handle that, but there may still be some inconsistencies with the original file. If this is correct, please let me know, so I can add a fix to this PR.

This is correct, please add a fix to this PR.

[artaleks9]

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1271 - the functionality works as expected.

[akurinnoy]

@olexii4 please take a look one more time.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1271

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1271", name: che-dashboard}]}}]"

[olexii4]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devspacesbuild]

Build 3.19 :: dashboard_3.x/601: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: sync-to-downstream_3.x/8266: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8343: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: push-latest-container-to-quay_3.x/5034: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8343:

dashboard : 3.x :: Build 66155098 : quay.io/devspaces/dashboard-rhel9:3.19-1
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/5034 triggered

[devspacesbuild]

Build 3.19 :: update-digests_3.x/8148: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: dashboard_3.x/601:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8266 triggered

[devspacesbuild]

Build 3.19 :: operator-bundle_3.x/4029: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: sync-to-downstream_3.x/8268: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8345: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8345:

devspaces-operator-bundle : 3.x :: Failed in 66155749 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay