Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/nodejs-18:1-128 to ubi8/nodejs-18:1-133.1731463548 #1270

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Nov 30, 2024

Signed-off-by: Nick Boldt [email protected]

@openshift-ci-robot
Copy link

@che-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@che-bot
Copy link
Contributor Author

che-bot commented Nov 30, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1270

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1270", name: che-dashboard}]}}]"

@akurinnoy
Copy link
Contributor

/retest

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (930cd8a) to head (17e9ac6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   91.53%   91.57%   +0.03%     
==========================================
  Files         497      497              
  Lines       45501    45501              
  Branches     3163     3155       -8     
==========================================
+ Hits        41651    41667      +16     
+ Misses       3820     3803      -17     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akurinnoy akurinnoy merged commit b5e6780 into main Dec 5, 2024
19 of 21 checks passed
@akurinnoy akurinnoy deleted the pr-update-base-images-1732925121 branch December 5, 2024 08:52
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/600: Console, Changes, Git Data

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, che-bot, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8306: FAILURE

dashboard : 3.x :: Failed in 66114892 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants